Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to add/delete relationship for all actors #3254

Conversation

shahzadlone
Copy link
Member

@shahzadlone shahzadlone commented Nov 18, 2024

Relevant issue(s)

Resolves #3255

Description

  • Can target all actors using "*" to add or delete acp relationships.
  • All explicitly added relationships are unaffected upon revocation using "*" (they will keep access).

For Reviewers

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

  • Integration tests

Specify the platform(s) on which this was tested:

  • Manjaro WSL2

@shahzadlone shahzadlone changed the title TEST: Check if passing "*" works, it doesn't as current implementatio… feat: Add ability to set relation for all actors Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.14%. Comparing base (e2c657e) to head (c67cb42).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3254      +/-   ##
===========================================
+ Coverage    77.97%   78.14%   +0.17%     
===========================================
  Files          382      382              
  Lines        35308    35364      +56     
===========================================
+ Hits         27531    27634     +103     
+ Misses        6135     6103      -32     
+ Partials      1642     1627      -15     
Flag Coverage Δ
all-tests 78.14% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
acp/acp_local.go 98.05% <100.00%> (+0.33%) ⬆️
acp/acp_source_hub.go 73.49% <100.00%> (+2.07%) ⬆️
cli/acp_relationship_add.go 100.00% <100.00%> (ø)
client/db.go 89.29% <ø> (ø)

... and 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2c657e...c67cb42. Read the comment docs.

@shahzadlone shahzadlone force-pushed the lone/demo-share-perm-with-all-actors branch 2 times, most recently from 0952ef4 to 8a279a7 Compare November 21, 2024 18:20
@shahzadlone shahzadlone added this to the DefraDB v0.15 milestone Nov 21, 2024
@shahzadlone shahzadlone added feature New feature or request area/acp Related to the acp (access control) system labels Nov 21, 2024
@shahzadlone shahzadlone changed the title feat: Add ability to set relation for all actors feat: Add ability to add/delete relationships for all actors Nov 21, 2024
@shahzadlone shahzadlone force-pushed the lone/demo-share-perm-with-all-actors branch from 8a279a7 to a3c2820 Compare November 21, 2024 20:05
@shahzadlone shahzadlone marked this pull request as ready for review November 21, 2024 20:05
@shahzadlone shahzadlone requested a review from a team November 21, 2024 20:06
@shahzadlone shahzadlone self-assigned this Nov 21, 2024
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one minor todo before merge. And thanks for documenting in the acp readme.

tests/integration/identity.go Show resolved Hide resolved
@shahzadlone shahzadlone force-pushed the lone/demo-share-perm-with-all-actors branch from a3c2820 to 54d148d Compare November 25, 2024 19:28
@shahzadlone shahzadlone changed the title feat: Add ability to add/delete relationships for all actors feat: Add ability to add/delete relationship targeting any actor Nov 25, 2024
@shahzadlone shahzadlone changed the title feat: Add ability to add/delete relationship targeting any actor feat: Add ability to target any/all actors in a relationship Nov 25, 2024
@shahzadlone shahzadlone changed the title feat: Add ability to target any/all actors in a relationship feat: Add ability to add/delete relationship for all actors Nov 25, 2024
@shahzadlone shahzadlone force-pushed the lone/demo-share-perm-with-all-actors branch 3 times, most recently from f61d27e to eaf7c27 Compare November 25, 2024 21:49
@shahzadlone shahzadlone force-pushed the lone/demo-share-perm-with-all-actors branch from eaf7c27 to c67cb42 Compare November 26, 2024 00:24
@shahzadlone shahzadlone merged commit c7b8b93 into sourcenetwork:develop Nov 26, 2024
42 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/acp Related to the acp (access control) system feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to set relation for all actors using "*"
2 participants