-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability to add/delete relationship for all actors #3254
feat: Add ability to add/delete relationship for all actors #3254
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3254 +/- ##
===========================================
+ Coverage 77.97% 78.14% +0.17%
===========================================
Files 382 382
Lines 35308 35364 +56
===========================================
+ Hits 27531 27634 +103
+ Misses 6135 6103 -32
+ Partials 1642 1627 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
0952ef4
to
8a279a7
Compare
8a279a7
to
a3c2820
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one minor todo before merge. And thanks for documenting in the acp readme.
a3c2820
to
54d148d
Compare
f61d27e
to
eaf7c27
Compare
eaf7c27
to
c67cb42
Compare
Relevant issue(s)
Resolves #3255
Description
"*"
to add or delete acp relationships."*"
(they will keep access).For Reviewers
Tasks
How has this been tested?
Specify the platform(s) on which this was tested: