-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make requests with no identity work with "*" target #3278
fix: Make requests with no identity work with "*" target #3278
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3278 +/- ##
===========================================
+ Coverage 77.97% 78.07% +0.11%
===========================================
Files 382 382
Lines 35383 35390 +7
===========================================
+ Hits 27587 27630 +43
+ Misses 6149 6123 -26
+ Partials 1647 1637 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 18 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
1ceda7a
to
ef4df0a
Compare
tests/integration/acp/relationship/doc_actor/add/with_target_all_actors_gql_test.go
Show resolved
Hide resolved
tests/integration/acp/relationship/doc_actor/add/with_target_all_actors_gql_test.go
Show resolved
Hide resolved
tests/integration/acp/relationship/doc_actor/add/with_target_all_actors_test.go
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one minor suggestion to clarify comment in the integration test.
tests/integration/acp/relationship/doc_actor/add/with_target_all_actors_gql_test.go
Outdated
Show resolved
Hide resolved
aff3af2
to
6c01501
Compare
(after revokation)
6c01501
to
6a7d5b9
Compare
Relevant issue(s)
Resolves #3276
Description
Tasks
How has this been tested?
Specify the platform(s) on which this was tested: