Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i): Fetcher wrapper panic #3400

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

nasdf
Copy link
Member

@nasdf nasdf commented Jan 20, 2025

Relevant issue(s)

Resolves #3399

Description

This PR fixes an issue where the Start function of wrappingFetcher would not return an error causing a seg fault when trying to access the fetcher in a subsequent FetchNext call.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

No added tests. I'm unsure if this is worth testing with mocks, but open to suggestions.

Specify the platform(s) on which this was tested:

  • MacOS

@nasdf nasdf added the bug Something isn't working label Jan 20, 2025
@nasdf nasdf added this to the DefraDB v0.16 milestone Jan 20, 2025
@nasdf nasdf self-assigned this Jan 20, 2025
@nasdf nasdf changed the title fix(i): fetcher wrapper panic fix(i): Fetcher wrapper panic Jan 20, 2025
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooof, my bad, thanks Keenan 😅

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.26%. Comparing base (f24fda4) to head (544ede0).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
internal/db/fetcher/wrapper.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3400      +/-   ##
===========================================
+ Coverage    78.11%   78.26%   +0.15%     
===========================================
  Files          392      392              
  Lines        36045    36045              
===========================================
+ Hits         28155    28208      +53     
+ Misses        6208     6171      -37     
+ Partials      1682     1666      -16     
Flag Coverage Δ
all-tests 78.26% <0.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/db/fetcher/wrapper.go 82.11% <0.00%> (ø)

... and 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f24fda4...544ede0. Read the comment docs.

@nasdf nasdf merged commit 486f9da into sourcenetwork:develop Jan 20, 2025
41 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetcher panics sometimes in CI
2 participants