refactor: Remove utils package #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzadlone
added
the
action/no-benchmark
shahzadlone
requested review from
orpheuslummis,
jsimnz,
fredcarle and
AndrewSisley
Codecov Report
@@ Coverage Diff @@
## develop #397 +/- ##
===========================================
+ Coverage 65.49% 65.64% +0.14%
===========================================
Files 81 80 -1
Lines 9492 9471 -21
===========================================
Hits 6217 6217
+ Misses 2645 2624 -21
Partials 630 630
|
shahzadlone
commented
May 5, 2022
|
|
||
| import ( | ||
| "github.com/ipfs/go-cid" | ||
| mh "github.com/multiformats/go-multihash" | ||
| ) | ||
|
|
||
| func NewCidV1(data []byte) (cid.Cid, error) { |
There was a problem hiding this comment.
Noticed we were using another function with a similar name from ipfs/go-cid, signature: func NewCidV1(codecType uint64, mhash mh.Multihash) Cid {...} in datastore/blockstore.go and api/http/api.go.
so, changed the name to differentiate and to be explicit about always having SHA2_256 MhType (fine to revert back to the same name if there is preference).
AndrewSisley
approved these changes
May 5, 2022
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
- RELATED ISSUE(S): Resolves sourcenetwork#396 - DESCRIPTION: Remove the utils package to avoid import dependencies between multiple packages. Devs are ready to have a little code duplication as a trade off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #396