Code

refactor: Refactor commit nodes#892

Code

Merged

AndrewSisley merged 18 commits intodevelopsourcenetwork/defradb:developfrom sisley/refactor/I858-refactor-commitNodesourcenetwork/defradb:sisley/refactor/I858-refactor-commitNodeCopy head branch name to clipboardOct 14, 2022

+311-579

Commits

Commits on Oct 12, 2022

• Remove headsetScanNode

  Show description for ce378a4
  AndrewSisley

  committed
  ce378a4

  Copy full SHA for ce378a4

• Make cid an option-type

  Show description for 2b69929
  AndrewSisley

  committed
  2b69929

  Copy full SHA for 2b69929

• Use parsed.Cid over duplicate prop

  AndrewSisley

  committed
  cf569d5

  Copy full SHA for cf569d5

• Dont store iteration state

  Show description for 0f167c7
  AndrewSisley

  committed
  0f167c7

  Copy full SHA for 0f167c7

• Remove legacy comment

  AndrewSisley

  committed
  04ff960

  Copy full SHA for 04ff960

• Use parsed.Depth over duplicate prop

  AndrewSisley

  committed
  f264ffc

  Copy full SHA for f264ffc

• Use parsed.DocKey over duplicate prop

  AndrewSisley

  committed
  d379bce

  Copy full SHA for d379bce

• Use parsed.Field over duplicate prop

  Show description for d5139a1
  AndrewSisley

  committed
  d5139a1

  Copy full SHA for d5139a1

• Simplify commit node constructor

  AndrewSisley

  committed
  dfd62df

  Copy full SHA for dfd62df

• Set currentValue only when valid

  Show description for 9964f97
  AndrewSisley

  committed
  9964f97

  Copy full SHA for 9964f97

• Replace legacy comment with correct comment

  AndrewSisley

  committed
  d988844

  Copy full SHA for d988844

• Add cid related comment

  AndrewSisley

  committed
  b35455b

  Copy full SHA for b35455b

• Remove type-unsafe list with slice magic

  AndrewSisley

  committed
  8ebce75

  Copy full SHA for 8ebce75

• Remove odd comment

  AndrewSisley

  committed
  1540686

  Copy full SHA for 1540686

• Remove commitSelectNode

  Show description for ce25ecb
  AndrewSisley

  committed
  ce25ecb

  Copy full SHA for ce25ecb

• Remove commitSelectTopNode

  Show description for 3bdd229
  AndrewSisley

  committed
  3bdd229

  Copy full SHA for 3bdd229

• FIXUP - reverse if-else

  Show description for a31ddd8
  AndrewSisley

  committed
  a31ddd8

  Copy full SHA for a31ddd8

Commits on Oct 14, 2022

• PR FIXUP - simplify queued cid construction

  AndrewSisley

  committed
  f2d5e84

  Copy full SHA for f2d5e84