Bug: report_results.sh sometimes sets incorrect cmake path #385
Assignees
Labels
Comments
|
I don't recall at the moment. I'm definitely confused as to why this is the
greedy version. (Two %s instead of just one.) One % should fix this...) Git
blame (or better yet open in github and click "blame") should show the
commit that introduced this which hopefully will have some context.
…On Thu, May 11, 2017 at 5:53 PM Damian Rouson ***@***.***> wrote:
Avg response time
![Issue Stats][issue stat img] Defect/bug report
In the current version of the Sourcery Institute VM, the cmake executable
in the PATH lives in a path that includes a directory named cmake
which cmake
/opt/cmake/3.7.0/bin/cmake
I suspect this is the reason that line 18
<https://github.com/sourceryinstitute/OpenCoarrays/blob/master/prerequisites/install-functions/report_results.sh#L18>
in report_results.sh yields the incorrect value:
cmake_install_path="${fully_qualified_CMAKE%%/cmake*}"
which assigns the value /opt. I will submit a pull request shortly that
fixes this. @zbeekman <https://github.com/zbeekman> is there some reason
that cmake was treated differently in the the path variables set near the
top of report_results.sh?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#385>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAREPF9Y058_n7VYy7l70UlqetPkw6qdks5r44NPgaJpZM4NYme8>
.
|
|
(I'll look when I'm back at my computer)
…On Thu, May 11, 2017 at 7:56 PM Zaak Beekman ***@***.***> wrote:
I don't recall at the moment. I'm definitely confused as to why this is
the greedy version. (Two %s instead of just one.) One % should fix this...)
Git blame (or better yet open in github and click "blame") should show the
commit that introduced this which hopefully will have some context.
On Thu, May 11, 2017 at 5:53 PM Damian Rouson ***@***.***>
wrote:
> Avg response time
> ![Issue Stats][issue stat img] Defect/bug report
>
> In the current version of the Sourcery Institute VM, the cmake
> executable in the PATH lives in a path that includes a directory named
> cmake
>
> which cmake
> /opt/cmake/3.7.0/bin/cmake
>
> I suspect this is the reason that line 18
> <https://github.com/sourceryinstitute/OpenCoarrays/blob/master/prerequisites/install-functions/report_results.sh#L18>
> in report_results.sh yields the incorrect value:
>
> cmake_install_path="${fully_qualified_CMAKE%%/cmake*}"
>
> which assigns the value /opt. I will submit a pull request shortly that
> fixes this. @zbeekman <https://github.com/zbeekman> is there some reason
> that cmake was treated differently in the the path variables set near the
> top of report_results.sh?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#385>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AAREPF9Y058_n7VYy7l70UlqetPkw6qdks5r44NPgaJpZM4NYme8>
> .
>
|
zbeekman
added a commit
that referenced
this issue
May 23, 2017
…esults Issue 385 fix report_results.sh - Fixes #385
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Defect/bug report
In the current version of the Sourcery Institute VM, the
cmakeexecutable in thePATHlives in a path that includes a directory namedcmakeI suspect this is the reason that line 18 in report_results.sh yields the incorrect value:
which assigns the value
/opt. I will submit a pull request shortly that fixes this. @zbeekman is there some reason that cmake was treated differently in the the path variables set near the top of report_results.sh?The text was updated successfully, but these errors were encountered: