Non-interactive install options: -y/--yes-to-all #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` ./install.sh -y ``` or equivalently ``` ./install.sh --yes-to-all) ``` will now causes a non-interactive build by assuming affirmative responses to all user queries. Exception: if the user passes an installation prefix (via -i or --install-prefix), the user will be prompted for a password prior to the "make install" step. To avoid this, execute as `sudo ./install.sh...` with the consequence that all steps will execute with sudo privileges.
|
@zbeekman, I recommend adjusting the Travis-CI scripts to use this new option instead of the "yes | ./install.sh" approach. That would test this new option and would keep our testing more self-contained. |
|
LGTM I'll adjust Travis-CI by pushing another commit to this branch before merging |
|
Ok, Assuming all tests pass, I'm happy to merge this LGTM |
|
Thanks! I just deleted the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #191 by adding the following option:
or equivalently
will now causes a non-interactive build by assuming affirmative
responses to all user queries. Exception: if the user passes
an installation prefix (via -i or --install-prefix), the user
will be prompted for a password prior to the "make install" step.
To avoid this, execute as
sudo ./install.sh...with theconsequence that all steps will execute with sudo privileges.