Skip to content

Issue 399 rebased #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 9, 2017
Merged

Issue 399 rebased #430

merged 3 commits into from
Aug 9, 2017

Conversation

zbeekman
Copy link
Collaborator

@zbeekman zbeekman commented Aug 9, 2017

Avg response time coverage on master
Issue Stats Codecov branch

Summary of changes

Fix issue #399. Really implementing a function get_by_ref for allocatable components.

Rationale for changes

Previous implementation was errorneous and to expensive w/o any benefit.

Additional info and certifications

This pull request (PR) is a:

  • Bug fix
  • Feature addition
  • Other, Please describe:

I certify that

  • I have reviewed the contributing guidelines and followed the
    policies on:
    - Pull request (PR) naming to indicate work in progress (WIP),
    and to attach the PR to the appropriate bug report, or feature
    request issue
    - White space (no trailing white space or white space errors may
    be introduced)
    - Commenting code where it is non-obvious and non-trivial
    - Running tests locally, to ensure all of them pass
    - Maintaining or increasing test coverage
    - Logically atomic, self consistent and coherent commits
    - Commit message content
    - Waiting 24 hours before self-approving the pull request to
    give another OpenCoarrays developer a chance to review my
    proposed code

@zbeekman zbeekman mentioned this pull request Aug 9, 2017
4 tasks
 - Commit 722fba3 by @vehre split into two:
 - This white space cleanup commit
 - The following commit with substantive changes. Original message will
   be reproduced in subsequent commit
@zbeekman zbeekman force-pushed the issue-399-rebased branch from 6a1c049 to 8b8a9f4 Compare August 9, 2017 15:44
@codecov
Copy link

codecov bot commented Aug 9, 2017

Codecov Report

Merging #430 into master will increase coverage by 1.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
+ Coverage   38.05%   39.38%   +1.32%     
==========================================
  Files           3        3              
  Lines        1997     2105     +108     
  Branches      330      350      +20     
==========================================
+ Hits          760      829      +69     
- Misses       1127     1154      +27     
- Partials      110      122      +12

vehre added 2 commits August 9, 2017 11:56
 - New: unlimited depth of references
 - Changed: internal token and introduced sub-token
 - No optimization yet
 - Fixes #399

 Original commit, 722fba3, authored by
 @vehre, split into white space changes (previous commit) and substantive
 changes (this commit) by @zbeekman
@zbeekman zbeekman force-pushed the issue-399-rebased branch from 8b8a9f4 to 55e7e37 Compare August 9, 2017 15:56
@zbeekman
Copy link
Collaborator Author

zbeekman commented Aug 9, 2017

LGTM

Content virtually identical to previous PR and issue-399 branch. Diff after rebasing issue-399 on top of current master verifies this. "Self approving" ahead of the 24 hour period, but this is really Andre's work.

Approved with PullApprove

@zbeekman zbeekman merged commit 3a0fdce into master Aug 9, 2017
@zbeekman zbeekman deleted the issue-399-rebased branch August 9, 2017 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants