Experimental fpm build/test/install capability #758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit 1. Removes ~4K lines of bash installation scripts. 2. Adds a much smaller, more maintainable, and more portable Homebrew- and fpm-based installation script that works on macOS, Linux, and Windows Subsystem for Linux. 3. Adds a test/ subdirectory containing Garden unit tests that fpm can run. 4. Moves src/tests to tests/ to prevent fpm building the CTest tests because of a build error due to duplicate module names. 5. Adjusts the CMake script for the new tests/ directory location. 6. Brackets the legacy GASNet and OpenSHMEM libraries with C preprocessor macros to prevent fpm from compiling them. 7. Adds an example/ subdirectory with simple demonstration rograms that fpm can run. 8. Puts fpm.toml in a new .gitignore file to prevent naive uses of fpm. (fpm builds work only after the new installer has been and the new fpm.toml file has been copied to the top level of the soure tree.)
bradking
reviewed
Jun 14, 2022
This commit applies the patch provided Brad King in a review of PR #758.
bradking
reviewed
Jun 22, 2022
| @@ -964,7 +966,7 @@ endif() | |||
|
|
|||
| # Test bash installation scripts | |||
| include(cmake/AddInstallationScriptTest.cmake ) | |||
| add_installation_script_test(installation-scripts.sh src/tests/installation/) | |||
| add_installation_script_test(installation-scripts.sh tests/installation/) | |||
There was a problem hiding this comment.
This code adds the test-installation-scripts.sh test case that is failing in CI.
The test expects the prerequisites/use-case/bootstrap.sh file to exist, but it is removed by this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR
install.shfor macOS, Linux, and Windows Subsystem for Linux.test/subdirectory containing Garden unit tests thatfpmcan run.src/teststotests/to preventfpmfrom building the CTest tests because of a build error due to duplicate module names.tests/directory location.fpmfrom compiling them.example/subdirectory with simple demonstration programs that fpm can run.fpm.tomlin a new.gitignorefile to prevent naive uses offpm. (fpmbuilds work only after the new version ofinstall.shhas been run and has copied the newfpm.tomlfile to the top-level source directory.)Rationale for changes
The old
install.shscript was large, complicated, difficult to maintain, and was written in an era before Homebrew was stable across macOS and Linux and long beforefpmexisted. The new installer first installs Homebrew if it's missing, then uses Homebrew to install all OpenCoarrays prerequisites, and finally builds OpenCoarrays withfpm, which enables developers to (re)build OpenCoarrays from source without CMake.Additional info and certifications
This pull request (PR) is a:
I certify that
OpenCoarrays developer a chance to review my proposed code
be introduced)
Code coverage data