Skip to content

Hop improvements #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 20, 2024
Merged

Hop improvements #52

merged 5 commits into from
Feb 20, 2024

Conversation

Jasonej
Copy link
Contributor

@Jasonej Jasonej commented Jan 31, 2024

  • Supports running commands like hop up -d --remove-orphans
    • @iBotPeaches let us know if this is potentially problematic in your eyes and we can consider something like a hop dss or hop rebuild command instead.
  • Adds a hop go utility that runs hop up -d and hop yarn dev or hop npm run dev as one command for easy boot up of a project.
    • Can also run hop go * to run hop yarn * or hop npm run *. Mostly applicable for the hop go build scenario where you want a production build of your project.

Jasonej and others added 3 commits January 31, 2024 12:13
@Jasonej @erik-perri
update: pass through args to dss command when running up to allow for…
dd5247d 
… --force-recreate and --remove-orphans

Co-authored-by: Erik Perri <erik.perri@sourcetoad.com>
@Jasonej @erik-perri
update: add hop go utility
f2f6d0a 
Co-authored-by: Erik Perri <erik.perri@sourcetoad.com>
@Jasonej @erik-perri
style: fix lint
a24ab18 
Co-authored-by: Erik Perri <erik.perri@sourcetoad.com>
erik-perri
erik-perri previously approved these changes Jan 31, 2024
View reviewed changes
iBotPeaches
iBotPeaches previously approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@iBotPeaches iBotPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

Bankamah
Bankamah previously approved these changes Jan 31, 2024
View reviewed changes
Vacoris
Vacoris previously approved these changes Jan 31, 2024
View reviewed changes
jyann
jyann reviewed Jan 31, 2024
View reviewed changes
jyann
jyann previously approved these changes Jan 31, 2024
View reviewed changes
charlesreffett
charlesreffett previously approved these changes Jan 31, 2024
View reviewed changes
@Jasonej @erik-perri
update: remove unneeded if check because yarn also supports using run
4063d1f 
Co-authored-by: Erik Perri <erik.perri@sourcetoad.com>
erik-perri
erik-perri previously approved these changes Jan 31, 2024
View reviewed changes
Vacoris
Vacoris previously approved these changes Jan 31, 2024
View reviewed changes
iBotPeaches
iBotPeaches previously approved these changes Jan 31, 2024
View reviewed changes
@erik-perri @Jasonej
update: stop running up during go if not needed
cb33378 
Co-authored-by: Jason Jones <jason@sourcetoad.com>
@erik-perri erik-perri dismissed stale reviews from iBotPeaches, Vacoris, and themself via cb33378 February 1, 2024 14:22
@iBotPeaches iBotPeaches merged commit 20fdceb into master Feb 20, 2024
@iBotPeaches iBotPeaches deleted the hop-improvements branch February 20, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iBotPeaches iBotPeaches iBotPeaches approved these changes

@jyann jyann jyann approved these changes

@erik-perri erik-perri erik-perri approved these changes

@Bankamah Bankamah Bankamah approved these changes

+2 more reviewers

@Vacoris Vacoris Vacoris approved these changes

@charlesreffett charlesreffett charlesreffett approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Jasonej @iBotPeaches @jyann @erik-perri @Vacoris @charlesreffett @Bankamah