Skip to content

build: remove 'version' property #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2024
Merged

build: remove 'version' property #57

merged 1 commit into from
Sep 13, 2024

Conversation

iBotPeaches
Copy link
Member

With docker-compose gone now - nothing reads version anymore. Thus we get warnings.

WARN[0000] DevopsToolKit/docker/data-source-services/docker-compose.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion

I'm sure if someone hasn't taken the upgrade that removes docker-compose for docker compose - they will soon.

@iBotPeaches iBotPeaches merged commit f55951c into master Sep 13, 2024
9 checks passed
@iBotPeaches iBotPeaches deleted the deprecation-version branch September 13, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyann jyann jyann approved these changes

@jweberst jweberst jweberst approved these changes

@erik-perri erik-perri erik-perri approved these changes

@Bankamah Bankamah Bankamah approved these changes

+2 more reviewers

@Vacoris Vacoris Vacoris approved these changes

@charlesreffett charlesreffett charlesreffett approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@iBotPeaches @jyann @jweberst @erik-perri @Vacoris @charlesreffett @Bankamah