Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getAllCompilerAbstracts method to compiler-artefacts.ts #1

Open
wants to merge 3 commits into
base: contract-verification-plugin-base-reviewing-base
Choose a base branch
from

Commits on Jun 14, 2024

  1. Add getAllCompilerAbstracts method to compiler-artefacts.ts

    The current compilerArtefacts plugin's existing methods had two flaws:
    1. It wasn't possible to get all Compiler Abstracts available in one go.
    2. It was possible to first get all files with `getAllContractsData` and then call each CompilerAbstract one by one with `getCompilerAbstract`, however, in that case the CompilerAbstract was missing the `input` because it wasn't passed to the contructor and saveCompilationPerFileResult. It was only done so for the `solidityUnitTesting` plugin listener.
    
    The compiler input is needed for consistent contract verification. While it's possible to generate a compiler input from the contract artefact, via the metadata, it is not always possible to get a match due to known bugs in compiler's AST generation in prev. versions. This results in different bytecode from the original compiler input's output vs the compilation output from the metadata file.
    kuzdogan committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    a148a7f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fcc0275 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Add compilationSaved event

    kuzdogan committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    2c4c424 View commit details
    Browse the repository at this point in the history