-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change name of gather output column avg_abund
to avg_cov
or avg_coverage
#1737
Comments
two hot takes - changing column names feels like kind of a big ask (requires major version bump), in relation to providing better documentation. "abundance" implies "coverage", I think. so it feels more general? anyway, tagging with 5.0 so we can consider it for major version bump. |
I think coverage has the connotation of "genome coverage", while abundance could refer to abundance within the genome or metagenome. But the the word "coverage" could be added to the documentation instead of changing the colname so that it carries that connotation? |
@bluegenes and I just had a conversation in slack trying to figure out what information is represented by the
avg_abund
column in the gather output csv. Using documentation like https://sourmash.readthedocs.io/en/latest/classifying-signatures.html, we figured out that it basically represents average coverage of the genome. We wanted to start a conversation about potentially changing the output column toavg_cov
, where the documentation would state that it's based on average k-mer abundances. We think this might be more intuitive.The text was updated successfully, but these errors were encountered: