Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider running flake8 and automatically fixing #2908

Closed
ctb opened this issue Jan 13, 2024 · 4 comments · Fixed by #2427
Closed

consider running flake8 and automatically fixing #2908

ctb opened this issue Jan 13, 2024 · 4 comments · Fixed by #2427
Assignees
@luizirber

Comments

@ctb
Copy link
Contributor

ctb commented Jan 13, 2024

per review

Flake8 revealed a lot of errors, it might not be the worst idea to run code through a linter and fix everything that can be automatically fixed, this may help with the unused imports as well. These are none critical but it helps.
@ctb ctb mentioned this issue Jan 13, 2024
Closed
33 tasks
@luizirber
Copy link
Member

time for #2427 to be updated?

@ctb
Copy link
Contributor Author

ctb commented Jan 14, 2024

I knew that PR was out there somewhere... yes, I think so. You up for it?

@luizirber
Copy link
Member

Yup

@luizirber luizirber self-assigned this Jan 14, 2024
@ctb
Copy link
Contributor Author

ctb commented Jan 30, 2024

bump! if it's easy...

@luizirber luizirber mentioned this issue Feb 5, 2024
Merged
luizirber added a commit that referenced this issue Feb 5, 2024
@luizirber
Pre-commit updates (#2427)
fee6292 
Ref #2421 
Fix #2908

Updates older pre-commit hooks (initial exp:
#680), mostly based (again)
on [tox
configs](https://github.com/tox-dev/tox/blob/main/.pre-commit-config.yaml)

Use ruff instead of pyupgrade/isort/black/flake8

This PR has a couple of commits: the first ones update configs, the last
one runs `tox -e fix_lint` to apply pre-commit. Mostly looking into
updating the first commits without breaking tests on the last commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luizirber luizirber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pre-commit updates sourmash-bio/sourmash
2 participants
@luizirber @ctb