Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] pin docutils to v0.16 to address doc building bug #1444

Merged
merged 1 commit into from
Apr 5, 2021
Merged

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Apr 5, 2021

This PR prevents docutils from upgrading to the latest release, v0.17, which causes some problems with Sphinx. See error message in #1437 for details.

Fixes #1437

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #1444 (c31ba9a) into latest (c49a8d8) will increase coverage by 5.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1444      +/-   ##
==========================================
+ Coverage   89.44%   94.59%   +5.14%     
==========================================
  Files         123       96      -27     
  Lines       19105    15491    -3614     
  Branches     1471     1471              
==========================================
- Hits        17089    14654    -2435     
+ Misses       1784      605    -1179     
  Partials      232      232              
Flag Coverage Δ
python 94.59% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/cmd.rs
src/core/tests/minhash.rs
src/core/src/sketch/minhash.rs
src/core/src/index/search.rs
src/core/src/encodings.rs
src/core/src/errors.rs
src/core/src/ffi/hyperloglog.rs
src/core/src/index/bigsi.rs
src/core/src/index/linear.rs
src/core/src/from.rs
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c49a8d8...c31ba9a. Read the comment docs.

@ctb
Copy link
Contributor Author

ctb commented Apr 5, 2021

hi @luizirber @bluegenes @keyabarve @erikyoung85 I think this is ready for review!

In terms of review, the thing to pay attention to is the GitHub Actions tests ("checks") on this PR. If you look at other recent builds (e.g. #1443), you'll see that Python 3.8 tests fail on both Mac OS X and Linux, as does the readthedocs build; while in this build, they succeed. That's because here I'm pinning the docutils version to an older release (v.016) to avoid an error caused by the Apr 3, 2021 of docutils v0.17.

So for review of this, all you need to do is verify that the checks above all pass for this PR, and say "Looks good to me!"

@ctb
Copy link
Contributor Author

ctb commented Apr 5, 2021

Note that all checks have now passed! So this is an easy review 😁

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@ctb ctb merged commit 058a016 into latest Apr 5, 2021
@ctb ctb deleted the pin/docutils branch April 5, 2021 14:25
@ctb
Copy link
Contributor Author

ctb commented Apr 5, 2021

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mysterious docs building failures in python3.8 builds - AttributeError on line_length_limit
2 participants