-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of ambiguous nucleotides #148
Conversation
Update PR to remove some now-unnecessary code, add a test
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
- Coverage 88.28% 88.21% -0.08%
==========================================
Files 18 18
Lines 2348 2342 -6
Branches 51 52 +1
==========================================
- Hits 2073 2066 -7
Misses 267 267
- Partials 8 9 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
This is a direct merge combining swamidass#2 + #138.
Addresses #137.
This PR updates behavior for non-ACGT nucleotides to the following:
sourmash compute
is run from the command line.add_sequence
raises an exception on k-mers containing non-ACGT, unlessforce
isTrue
.make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?