-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] add support for sourmash sketch fromfile
functionality.
#1884
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #1884 +/- ##
==========================================
+ Coverage 82.62% 90.55% +7.93%
==========================================
Files 121 91 -30
Lines 13109 8946 -4163
Branches 1756 1772 +16
==========================================
- Hits 10831 8101 -2730
+ Misses 2015 580 -1435
- Partials 263 265 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@bluegenes @mr-eyes if you have space to review this, it's merge-able at any time. I am (trying to) cleanly separate out the internal changes needed for robust support of #1885, but since each bolus of changes is independently good, might be nice to merge in the work every so often. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this lgtm
thx - will wait for tests to finish and then merge! nice to keep the PRs from getting too big 😆 |
This PR updates
command_sketch.py
andcommand_compute.py
to support newsourmash sketch fromfile
functionality, currently being developed in the ctb/2022-sourmash-sketchfrom repo and also in #1885.This is an ongoing PR that separates the support code changes from the
fromfile
command itself.This PR:
ComputeParameters
class to support__repr__
and__eq__
.ComputeParameters.to_param_str
method._signatures_for_sketch_factory
to properly handle no default_moltype and produce oneComputeParameters
object per ksize, along with general cleanup and refactoring.Ref #1671