-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] add some tests for Jaccard output ordering #1926
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #1926 +/- ##
==========================================
+ Coverage 82.93% 90.96% +8.03%
==========================================
Files 125 94 -31
Lines 13755 9479 -4276
Branches 1877 1877
==========================================
- Hits 11408 8623 -2785
+ Misses 2075 584 -1491
Partials 272 272
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
ready for review & merge @sourmash-bio/devs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are looking good to me.
This PR adds tests for optimized search
Index
classes (SBT
andLCA_Database
, currently) that ensure that we do not erroneously truncate searches. See #1925 for details.tl;dr more tests good.