-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] catch TypeError in search w/abund vs flat at the command line #1928
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #1928 +/- ##
==========================================
+ Coverage 82.94% 90.97% +8.03%
==========================================
Files 125 94 -31
Lines 13759 9483 -4276
Branches 1877 1877
==========================================
- Hits 11412 8627 -2785
+ Misses 2075 584 -1491
Partials 272 272
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
…o fix/search_type_error
@sourmash-bio/devs ready for review & merge! |
still ready for review & merge @sourmash-bio/devs :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR adjusts
search
to catch an exception that shouldn't be exposed to the user; here the exception is caused by searching a flat database with an abund signature.