Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Enum for simplifying molecule checks #765

Closed
wants to merge 2 commits into from
Closed

Conversation

luizirber
Copy link
Member

Initial exploration on using enums for controlling how minhashes are processed (discussion in #751)

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Oct 28, 2019

Codecov Report

Merging #765 into master will decrease coverage by 0.43%.
The diff coverage is 63.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #765      +/-   ##
==========================================
- Coverage   88.42%   87.99%   -0.44%     
==========================================
  Files          30       31       +1     
  Lines        4786     4813      +27     
  Branches       46       47       +1     
==========================================
+ Hits         4232     4235       +3     
- Misses        551      576      +25     
+ Partials        3        2       -1
Impacted Files Coverage Δ
sourmash/commands.py 88.15% <ø> (-0.15%) ⬇️
sourmash/kmer_min_hash.hh 99.04% <100%> (+0.98%) ⬆️
sourmash/hash_functions.py 22.22% <22.22%> (ø)
sourmash/signature_json.py 90.62% <52%> (-6.57%) ⬇️
sourmash/sourmash_args.py 96.18% <84.61%> (-0.4%) ⬇️
sourmash/lca/lca_utils.py 95.21% <0%> (-0.8%) ⬇️
sourmash/lca/command_index.py 90.26% <0%> (-0.45%) ⬇️
sourmash/sbt.py 85.21% <0%> (-0.32%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94ae59c...cab7ec6. Read the comment docs.

@netlify
Copy link

netlify bot commented Oct 29, 2019

Deploy preview for sourmash-docs ready!

Built with commit cab7ec6

https://deploy-preview-765--sourmash-docs.netlify.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant