-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] update gather implementations for LCA and SBT to use thresholding #843
Conversation
My main comment after this experience is that we need some tests to check that threshold_bp is being passed in properly to both LCA and SBT gather... or maybe generically for Index objects... |
Codecov Report
@@ Coverage Diff @@
## master #843 +/- ##
=========================================
Coverage ? 79.34%
=========================================
Files ? 83
Lines ? 7026
Branches ? 469
=========================================
Hits ? 5575
Misses ? 1151
Partials ? 300
Continue to review full report at Codecov.
|
I think I've addressed all the review issues? |
This is for optimization/performance improvement purposes; ref #838.
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?