Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] update gather implementations for LCA and SBT to use thresholding #843

Merged
merged 10 commits into from
Jan 14, 2020

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Jan 14, 2020

This is for optimization/performance improvement purposes; ref #838.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb ctb changed the title [WIP] update gather implementations for LCA and SBT to use thresholding [MRG] update gather implementations for LCA and SBT to use thresholding Jan 14, 2020
@ctb
Copy link
Contributor Author

ctb commented Jan 14, 2020

My main comment after this experience is that we need some tests to check that threshold_bp is being passed in properly to both LCA and SBT gather... or maybe generically for Index objects...

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@654bf42). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #843   +/-   ##
=========================================
  Coverage          ?   79.34%           
=========================================
  Files             ?       83           
  Lines             ?     7026           
  Branches          ?      469           
=========================================
  Hits              ?     5575           
  Misses            ?     1151           
  Partials          ?      300
Flag Coverage Δ
#pytests 89.91% <100%> (?)
#rusttests 48.71% <ø> (?)
Impacted Files Coverage Δ
sourmash/lca/lca_utils.py 96.61% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 654bf42...7327a7f. Read the comment docs.

@luizirber
Copy link
Member

Big improvements for LCA search and gather, not much difference for SBTs... (This PR is the gather on the X-axis)

LCA:
image
image

SBT:
image
image

@ctb
Copy link
Contributor Author

ctb commented Jan 14, 2020

I think I've addressed all the review issues?

@luizirber luizirber merged commit 4bd286b into master Jan 14, 2020
@luizirber luizirber deleted the optimize/gather branch January 14, 2020 18:06
@luizirber luizirber added this to the 3.1 milestone Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants