Skip to content

Commit

Permalink
Fixed data_dir path for both config/service
Browse files Browse the repository at this point in the history
@legal90 kindly pointed out that the default value for
['consul']['config']['data_dir'] & ['consul']['service']['data_dir']
was changed to append 'data' as the last folder. Consul actually
creates this directory for you when you start the service. And if
you didn't change both, it could cause the Consul agent to fail.
  • Loading branch information
Ginja committed Feb 2, 2016
1 parent f55f08b commit aac210a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion attributes/default.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
default['consul']['config']['bag_item'] = 'consul'

default['consul']['config']['path'] = join_path config_prefix_path, 'consul.json'
default['consul']['config']['data_dir'] = join_path data_prefix_path, 'data'
default['consul']['config']['data_dir'] = data_prefix_path
default['consul']['config']['ca_file'] = join_path config_prefix_path, 'ssl', 'CA', 'ca.crt'
default['consul']['config']['cert_file'] = join_path config_prefix_path, 'ssl', 'certs', 'consul.crt'
default['consul']['config']['key_file'] = join_path config_prefix_path, 'ssl', 'private', 'consul.key'
Expand Down
2 changes: 1 addition & 1 deletion test/spec/libraries/consul_service_linux_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
recipe 'consul::default'

it { expect(chef_run).to create_directory('/etc/consul/conf.d') }
it { is_expected.to create_directory('/var/lib/consul/data') }
it { is_expected.to create_directory('/var/lib/consul') }
end
end
2 changes: 1 addition & 1 deletion test/spec/libraries/consul_service_windows_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
recipe 'consul::default'

it { expect(chef_run).to create_directory('C:\Program Files\consul\conf.d') }
it { is_expected.to create_directory('C:\Program Files\consul\data') }
it { is_expected.to create_directory('C:\Program Files\consul') }
it { expect(chef_run).to install_nssm('consul').with(
program: 'C:\Program Files\consul\consul.exe',
args: 'agent -config-file="""C:\Program Files\consul\consul.json""" -config-dir="""C:\Program Files\consul\conf.d"""'
Expand Down

0 comments on commit aac210a

Please sign in to comment.