Remove 0.2 #10
Merged
Remove 0.2 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am fine with this but you need to update all of the checksums. |
|
sorry, I don't quite understand - update what checksums? I just removed everything from 0.2.0, 0.2.1 is still there an the checksums are fine. Am I missing something? |
|
Nevermind it looks like they are the same. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I vote to remove support for version 0.2.0. It leaks memory and doesn't support config key
advertise, which I'd like to support in an upcoming pr.More importantly, the ui zip of 0.2.0 is packaged differently that 0.2.1, so we would have to put in more machinery to differentiate the way we install it based on the old version number.
This is the first of a series of pull requests that all build on top of each other, I'm trying to package them individually, but that's not really possible.
Maybe you want to take a look at my master at https://github.com/bkw/consul-cookbook/tree/master, if you like all the changes, I could just prepare one large PR. What do you think?