Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for runit #16

Merged
merged 3 commits into from
Jun 11, 2014
Merged

Add support for runit #16

merged 3 commits into from
Jun 11, 2014

Conversation

webcoyote
Copy link
Contributor

Since /etc/init.d doesn't handle application crashes gracefully by restarting the consul application, I've updated the service recipe to >optionally< use runit (controlled by node[:consul][:init_style] since runit does handle application crashes. I've configured the default init_style to 'init' so that any current users of the cookbook won't be surprised by this addition.

Runit can also change the user/group of the consul application so it doesn't have to run as root. If the user selects runit init_style I update the /etc/consul.d, /var/log/consul and /var/lib/consul directories to be owned by that user/group instead of root/root.

Let me know if you'd like any additional changes to accept this pull request. I've tested my changes, and am running this in a development environment, where it's working perfectly.

Thanks for creating this cookbook, by the way!

@webcoyote
Copy link
Contributor Author

Rebased on top of master; now takes configuration from default.json file.

@johnbellone
Copy link
Contributor

That's all comments I have! Great work!

@webcoyote
Copy link
Contributor Author

I've made the three updates you suggested; thanks for the feedback.

johnbellone pushed a commit that referenced this pull request Jun 11, 2014
@johnbellone johnbellone merged commit 1718eb3 into sous-chefs:master Jun 11, 2014
@webcoyote webcoyote deleted the consul-runit branch June 11, 2014 19:25
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants