Fixes #262 for Windows #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can now remove previously set nssm parameters by setting the hash values to '' for Strings, & 0 for Integers. Also improved how the Consul service is stopped on Windows. If you don't stop it before you remove it, you end up in a SERVICE_PAUSED state.
If nssm reported SERVICE_PAUSED for the consul service, the nssm resource was unable to remove it. Altered the service status check so it's flexible to handle multiple exit statuses.
It appears the nssm resource also isn't idempotent. I also added another attribute and made it the default value for the install_path property for consul_service. My reasoning is that one should be able to change this crucial property without having to redeclare the whole resource. #262 will be fixed for linux once johnbellone/libartifact-cookbook#2 is merged
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears the nssm resource also isn't idempotent. I also added another
attribute and made it the default value for the install_path property for
consul_service. My reasoning is that one should be able to change this
crucial property without having to redeclare the whole resource. #262 will
be fixed for linux once
johnbellone/libartifact-cookbook#2 is merged