Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul_installation: Fix binary base url for Linux x86 #310

Merged
merged 1 commit into from
Apr 21, 2016

Conversation

legal90
Copy link
Contributor

@legal90 legal90 commented Apr 21, 2016

At the moment consul_installation_binary#binary_basename returns an invalid base url if node['kernel']['machine'] is not literally 'i386'.

Reproduced on CentOS 5.11 x86: attribute node['kernel']['machine'] is "i686" there, so the url became the following:

https://releases.hashicorp.com/consul/0.6.4/consul_0.6.4_linux_i686.zip
#403 "Forbidden"

However it should be:

https://releases.hashicorp.com/consul/0.6.4/consul_0.6.4_linux_386.zip

This PR fixes that issue.

Base name should be appended by "386" for all x86 platforms, including "i686".
@codecov-io
Copy link

Current coverage is 69.02%

Merging #310 into master will increase coverage by +19.81% as of 850d71e

@@            master    #310   diff @@
======================================
  Files            7       9     +2
  Stmts          380     381     +1
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            187     263    +76
  Partial          0       0       
+ Missed         193     118    -75

Review entire Coverage Diff as of 850d71e

Powered by Codecov. Updated on successful CI builds.

@johnbellone johnbellone merged commit 6dd7907 into sous-chefs:master Apr 21, 2016
@legal90 legal90 deleted the fix-x86 branch April 21, 2016 12:59
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants