Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating broken link on windows #357

Merged
merged 1 commit into from
Oct 7, 2016

Conversation

kamaradclimber
Copy link
Contributor

Change-Id: I45ae9496ab01f2430d056af9b084d0c9e7a91564

@legal90
Copy link
Contributor

legal90 commented Oct 7, 2016

@kamaradclimber Thanks!
But I'd recommend using the built-in helper windows? instead:

not_if { windows? }

That's just a common practice used in this cookbook as well as in Chef Client itself

@kamaradclimber
Copy link
Contributor Author

ok thanks for the tip

Change-Id: I45ae9496ab01f2430d056af9b084d0c9e7a91564
@codecov-io
Copy link

Current coverage is 59.44% (diff: 100%)

No coverage report found for master at d60cc91.

Powered by Codecov. Last update d60cc91...7a752b8

@kamaradclimber
Copy link
Contributor Author

done

@legal90
Copy link
Contributor

legal90 commented Oct 7, 2016

LGTM. I'm gonna merge this PR since the only failed build is ChefSpec, which is not relevant.
@kamaradclimber Thanks for the contribution!

@legal90 legal90 merged commit 7abb7b3 into sous-chefs:master Oct 7, 2016
@kamaradclimber kamaradclimber deleted the link branch October 7, 2016 12:42
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants