Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the following parameters in consul config supported in version 0.… #380

Merged
merged 4 commits into from
Dec 15, 2016

Conversation

iliasbertsimas
Copy link

@iliasbertsimas iliasbertsimas commented Nov 29, 2016

…7.1 and after:

  • raft_multiplier
  • reap
  • retry_join_ec2 (Hash)
  • serf_lan_bind
  • serf_wan_bind

Copy link
Contributor

@legal90 legal90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the contribution! 👍
But seems like max_stale should not be defined as an attribute since it's not a top-level option.

@@ -69,10 +69,13 @@ class ConsulConfig < Chef::Resource
attribute(:key_file, kind_of: String)
attribute(:leave_on_terminate, equal_to: [true, false], default: false)
attribute(:log_level, equal_to: %w(INFO DEBUG WARN), default: 'INFO')
attribute(:max_stale, kind_of: String)

This comment was marked as outdated.

@@ -82,7 +85,10 @@ class ConsulConfig < Chef::Resource
attribute(:retry_interval_wan, kind_of: String)
attribute(:retry_join, kind_of: Array)
attribute(:retry_join_wan, kind_of: Array)
attribute(:retry_join_ec2, kind_of: [Hash, Mash])

This comment was marked as outdated.

@legal90 legal90 merged commit 4c70c62 into sous-chefs:master Dec 15, 2016
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants