Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Consul support to 0.7.4, some bug fixes #408

Merged
merged 1 commit into from
Feb 9, 2017
Merged

Update Consul support to 0.7.4, some bug fixes #408

merged 1 commit into from
Feb 9, 2017

Conversation

jasonmcintosh
Copy link

Added 0.7.3 binary sums
Changed default to 0.7.3
Removed freebsd binary sums
Fixed some source install - go version 1.7 requirement, build path, zip dependency

@codecov-io
Copy link

codecov-io commented Feb 2, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@82fac06). Click here to learn what that means.

@@            Coverage Diff            @@
##             master     #408   +/-   ##
=========================================
  Coverage          ?   71.84%           
=========================================
  Files             ?        7           
  Lines             ?      341           
  Branches          ?        0           
=========================================
  Hits              ?      245           
  Misses            ?       96           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82fac06...a14d781. Read the comment docs.

@jasonmcintosh jasonmcintosh changed the title Update Consul support to 0.7.3, some bug fixes Update Consul support to 0.7.4, some bug fixes Feb 8, 2017
Copy link
Contributor

@legal90 legal90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good to me except the version bump. As I know, the next release is gonna be 3.0.0.

metadata.rb Outdated
@@ -4,7 +4,7 @@
license 'Apache 2.0'
description 'Application cookbook which installs and configures Consul.'
long_description 'Application cookbook which installs and configures Consul.'
version '2.3.1'
version '2.3.2'

This comment was marked as outdated.

This comment was marked as outdated.

Copy link
Contributor

@legal90 legal90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, but we need to get TravisCI builds passed.

@@ -4,7 +4,7 @@
#
# Copyright 2014-2016, Bloomberg Finance L.P.
#

default['go']['version'] = '1.7'

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@@ -32,7 +32,7 @@

default['consul']['service']['config_dir'] = join_path config_prefix_path, 'conf.d'

default['consul']['version'] = '0.7.2'
default['consul']['version'] = '0.7.3'

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@jasonmcintosh
Copy link
Author

K - I THINK that I've got all the changes we've talked about worked out. This includes the move of the default attribute for go to the kitchen test, an update to the README to warning about the go dependency version issue for the git installation versions, as well as the metadata.rb reverted to the prior version.

@legal90
Copy link
Contributor

legal90 commented Feb 9, 2017

Thanks! I've just rebased the branch, so let's wait for a TravisCI build

@legal90 legal90 merged commit 49b4b3f into sous-chefs:master Feb 9, 2017
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants