-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Consul support to 0.7.4, some bug fixes #408
Conversation
Codecov Report
@@ Coverage Diff @@
## master #408 +/- ##
=========================================
Coverage ? 71.84%
=========================================
Files ? 7
Lines ? 341
Branches ? 0
=========================================
Hits ? 245
Misses ? 96
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks good to me except the version bump. As I know, the next release is gonna be 3.0.0.
metadata.rb
Outdated
@@ -4,7 +4,7 @@ | |||
license 'Apache 2.0' | |||
description 'Application cookbook which installs and configures Consul.' | |||
long_description 'Application cookbook which installs and configures Consul.' | |||
version '2.3.1' | |||
version '2.3.2' |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, but we need to get TravisCI builds passed.
attributes/default.rb
Outdated
@@ -4,7 +4,7 @@ | |||
# | |||
# Copyright 2014-2016, Bloomberg Finance L.P. | |||
# | |||
|
|||
default['go']['version'] = '1.7' |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
attributes/default.rb
Outdated
@@ -32,7 +32,7 @@ | |||
|
|||
default['consul']['service']['config_dir'] = join_path config_prefix_path, 'conf.d' | |||
|
|||
default['consul']['version'] = '0.7.2' | |||
default['consul']['version'] = '0.7.3' |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
K - I THINK that I've got all the changes we've talked about worked out. This includes the move of the default attribute for go to the kitchen test, an update to the README to warning about the go dependency version issue for the git installation versions, as well as the metadata.rb reverted to the prior version. |
Thanks! I've just rebased the branch, so let's wait for a TravisCI build |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Added 0.7.3 binary sums
Changed default to 0.7.3
Removed freebsd binary sums
Fixed some source install - go version 1.7 requirement, build path, zip dependency