Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "service_user" and "service_group" attributes as defaults for resource params #445

Merged
merged 2 commits into from
Jun 11, 2017

Conversation

legal90
Copy link
Contributor

@legal90 legal90 commented May 30, 2017

It looks like a mistake existing for a long time already.
Regardless of their names, attributes ['consul']['service_user'] and ['consul']['service_group'] don't actually affect the user running Consul as well as permissions for ['consul']['config']['data_dir'] directory.

This PR fixes that. Now user and group params of consul_service resource have default values as ['consul']['service_user'] and ['consul']['service_group'] appropriately.

@legal90 legal90 requested review from johnbellone and Ginja May 30, 2017 19:56
@legal90 legal90 added this to the v3.0.0 milestone May 30, 2017
@legal90 legal90 changed the title consul_service: Get user and group defaults from attribute value Use "service_user" and "service_group" attributes as defaults for resource params May 30, 2017
@legal90
Copy link
Contributor Author

legal90 commented May 30, 2017

I've added the same for consul_watch resource as well, so now it behaves similar to consul_definitions (in terms of owner&group of the file generated)

@sous-chefs sous-chefs deleted a comment from codecov-io Jun 11, 2017
@legal90 legal90 merged commit cbe87ae into sous-chefs:master Jun 11, 2017
@legal90 legal90 deleted the fix-service-permissions branch June 11, 2017 12:16
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant