Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul_config: Remove default values #447

Merged
merged 1 commit into from
Jun 11, 2017

Commits on May 31, 2017

  1. consul_config: Remove default values

    We don't need to set these defaults values because:
    1) These default values are rendered to the `consul.json` config file only if an appropriate argument was called in the `consul_config` resource source code. For example, currently we have `verify_incoming` and `verify_outgoing` always rendered in the config file because they are called there, in #tls? helper.
    
    2) Consul can handle default values by itself.
    We just don't need to render them in the config file unless we really need to set them explicitly. It makes a big sense for consul config options which have different default values in different Consul agent versions. For example, `acl_enforce_version_8` defaults to _false_ in versions of Consul prior to 0.8, and defaults to _true_ in Consul 0.8 and later.
    legal90 committed May 31, 2017
    Configuration menu
    Copy the full SHA
    bd294b5 View commit details
    Browse the repository at this point in the history