API updates & Add encrypt param #56
Conversation
- Update serverspec API usage - Update how ui is extracted, the file itself changed - Increase coverage slightly with added test when using runit - Cleanup helpers with more convenience methods Add encrypt parameter - Add test - Add value to kitchen config
|
Thanks @benjaminws ! |
| @@ -19,9 +19,9 @@ | |||
| install_checksum = node['consul']['checksums'].fetch(install_version) | |||
|
|
|||
| ark 'consul_ui' do | |||
| path node['consul']['ui_dir'] | |||
| path node['consul']['data_dir'] | |||
| home_dir node['consul']['ui_dir'] | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
One thing, I noticed about the pull request is "encrypt" attribute is not present in the default attribute. Why is that so? Ideally, we should use the data bags for that. |
|
@thedebugger Ahh, good eye. The default for the attribute is nil, so it is not in the default attributes. Check out https://github.com/johnbellone/consul-cookbook/blob/master/recipes/_service.rb#L113 to see how it decides when to use the attribute. Also, I didn't document usage in this pull request, but have corrected that in #57 |
This is a version bump as commits for #56 caused some breaking changes. Since we haven't pushed 0.4.4 yet to supermarket (or tagged release, for that matter) let's bump this. There are a few pull-requests that we are waiting on prior to release.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Cleaned up previous PR.
API updates
Add encrypt parameter