Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tls support #58

Merged
merged 3 commits into from
Nov 18, 2014
Merged

Add tls support #58

merged 3 commits into from
Nov 18, 2014

Conversation

thedebugger
Copy link
Contributor

  • Add the missing bootstrap_expect param
  • Add the missing encrypt param
  • Add encrypt_enabled param to make Consul gossip encryption explicit

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 50d24d2 on thedebugger:add_tls_support into 0aa95e9 on johnbellone:master.

johnbellone
johnbellone reviewed Oct 22, 2014
View reviewed changes
attributes/default.rb
default['consul']['data_dir'] = '/var/lib/consul'
default['consul']['config_dir'] = '/etc/consul.d'
default['consul']['config_dir'] = config_dir

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

@johnbellone johnbellone added this to the 0.5.0 milestone Oct 22, 2014
@johnbellone
Copy link
Contributor

@reset Any thoughts on service recipe? I'd rather not touch something that works but I'm starting to 💤 looking at it.

@reset
Copy link
Contributor

reset commented Oct 24, 2014

@johnbellone what are you trying to change about it?

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a8d5aad on thedebugger:add_tls_support into 0aa95e9 on johnbellone:master.

@johnbellone
Copy link
Contributor

I have just been seeing a lot of reoccurring patterns with services since we don't use runit internally. I'll take a stab at fixing it as a separate library cookbook!

@johnbellone
Copy link
Contributor

@thedebugger Can you rebase?

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling b29db90 on thedebugger:add_tls_support into 3643ab6 on johnbellone:master.

@johnbellone
Copy link
Contributor

It looks like there is a merge conflict that you'll need to deal with before I can merge PR!

what do you want? added 3 commits November 17, 2014 15:36
Add TLS support
59ed0aa 
- Add the missing bootstrap_expect param
- Add the missing encrypt param
- Add encrypt_enabled param to make gossip encryption explict
Add missing databag documentation
3edb2d8
Derive certs path from config_dir
8031632 
More on that: https://coderanger.net/derived-attributes/
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 8031632 on thedebugger:add_tls_support into 2ee2df4 on johnbellone:master.

johnbellone added a commit that referenced this pull request Nov 18, 2014
@johnbellone
Merge pull request #58 from thedebugger/add_tls_support
5a4e1a4 
Add tls support
@johnbellone johnbellone merged commit 5a4e1a4 into sous-chefs:master Nov 18, 2014
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.
4 participants
@thedebugger @coveralls @johnbellone @reset