-
-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker Swarm support #1296
base: main
Are you sure you want to change the base?
Add Docker Swarm support #1296
Conversation
7e67a85
to
2926f70
Compare
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 8 out of 23 changed files in this pull request and generated 1 comment.
Files not reviewed (15)
- .tool-versions: Language not supported
- README.md: Evaluated as low risk
- CHANGELOG.md: Evaluated as low risk
- kitchen.yml: Evaluated as low risk
- .github/workflows/ci.yml: Evaluated as low risk
- kitchen.exec.yml: Evaluated as low risk
- documentation/docker_swarm_service.md: Evaluated as low risk
- test/cookbooks/docker_test/recipes/swarm_default.rb: Evaluated as low risk
- spec/unit/resources/swarm_service_spec.rb: Evaluated as low risk
- documentation/docker_swarm_token.md: Evaluated as low risk
- resources/swarm_init.rb: Evaluated as low risk
- test/cookbooks/docker_test/recipes/swarm_init.rb: Evaluated as low risk
- spec/unit/resources/swarm_join_spec.rb: Evaluated as low risk
- documentation/docker_swarm_init.md: Evaluated as low risk
- resources/swarm_join.rb: Evaluated as low risk
Comments suppressed due to low confidence (2)
resources/swarm_token.rb:25
- [nitpick] The error message could be more descriptive by specifying which token type it failed to get.
raise "Error getting #{token_type} token: #{cmd.stderr}" if cmd.error?
resources/swarm_token.rb:38
- [nitpick] The error message could be more descriptive by specifying which token type it failed to rotate.
raise "Error rotating #{token_type} token: #{cmd.stderr}" if cmd.error?
- Adds swarm init, join, service & token resources Signed-off-by: Dan Webb <dan.webb@damacus.io>
Signed-off-by: Dan Webb <dan.webb@damacus.io>
Signed-off-by: Dan Webb <dan.webb@damacus.io>
df12aea
to
d9147cd
Compare
github actions flagged your matrix of OS's as missing 2 spaces in the indentation in your ci.yaml file causing the yaml lint job to fail. |
Signed-off-by: Dan Webb dan.webb@damacus.io