Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Elasticsearch 5.0.0 #503

Closed
martinb3 opened this issue Oct 12, 2016 · 4 comments
Closed

Support Elasticsearch 5.0.0 #503

martinb3 opened this issue Oct 12, 2016 · 4 comments
Milestone
Major version v3.0.0

Comments

@martinb3
Copy link
Contributor

martinb3 commented Oct 12, 2016 •
edited
Loading

We should support ES v5, and drop support for a few of the older things we've been doing. I'll make a milestone for this as well. We'll break compatibility and ship >= 5.0.0 support in a new major version of the cookbook, since there's so much changed.
@martinb3 martinb3 added this to the Major version v3.0.0 milestone Oct 12, 2016
@martinb3 martinb3 mentioned this issue Oct 12, 2016
Closed
@wfindley
Copy link

you'll need to refactor the elasticsearch_plugin resource. It's expecting something like /opt/elasticsearch/bin/plugin, but it looks like 5.0 calls it /opt/elasticsearch/bin/elasticsearch-plugin.

@wfindley
Copy link

ha. Just read https://www.elastic.co/blog/running-site-plugins-with-elasticsearch-5-0. Refactoring elasticsearch_plugin seems the least of our concerns.

@wfindley
Copy link

needed to change the initfile to use
daemon --user $ES_USER --pidfile $pidfile $exec -p $pidfile -d -Edefault.path.logs=$LOG_DIR -Edefault.path.data=$DATA_DIR -Edefault.path.conf=$CONF_DIR

also needed a log4j2.properties.erb

I just looked at the RPM and stole out of there.

@martinb3
Copy link
Contributor Author

Hi @wfindley -- this is just an overall issue for the entire transition. We've got a bunch of individual issues with specific changes we need to make.

@martinb3 martinb3 assigned martinb3 and unassigned martinb3 Oct 24, 2016
martinb3 added a commit that referenced this issue Oct 27, 2016
@martinb3
Bump minimum Chef versions
36f4efb 
- Leave 12.4 as metadata.rb minimum
- Start testing against latest three versions
- Update docs to indicate what we test

RE: #503
RE: #505
martinb3 added a commit that referenced this issue Oct 28, 2016
@martinb3
Add support for ES 5.0
e08a680 
- Drop support for ES < 5.0
  * Remove the shield/watcher plugin installs, since they have become x-pack in ES 5.0
  * Remove hashes and different download URLs, other logic that distinguishes between 1.x and 2.x.
  * Update README.md to reflect that this change drops support for < 5.0 (too many changes)

- elasticsearch_install:
  * Drop warnings for installing as root under ES < 2.0

- elasticsearch_configure:
  * Replace logging.yml with new log4j2.properties file, add template for this
  * Update variables that are allowed in /etc/sysconfig/elasticsearch or /etc/default/elasticsearch
  * Drop ES_JAVA_OPTS and introduce option 'jvm_options' with new template for /etc/elasticsearch/jvm.options
  * Add new restart_on_upgrade option, drop thread_stack_size, drop env_options, drop gc_settings
  * Drop some of the defaults in elasticsearch.yml that are no longer present in upstream packaging

- elasticsearch_plugin:
  * change bin/plugin to bin/elasticsearch-plugin when managing plugins
  * Remove the shield/watcher plugin installs, since they have become x-pack in ES 5.0
  * Add new `options` parameter/attribute so that you can pass things like `--batch` to this resource

- elasticsearch_service:
  * Introduce systemd unit files for distros that support them
  * Guard on which init systems based on presence of /etc/init.d or /usr/lib/systemd/system directories

Fixes #424.
Fixes #478.
Fixes #503.
martinb3 added a commit that referenced this issue Oct 28, 2016
@martinb3
Add support for ES 5.0
1ccd013 
- Drop support for ES < 5.0
  * Remove the shield/watcher plugin installs, since they have become x-pack in ES 5.0
  * Remove hashes and different download URLs, other logic that distinguishes between 1.x and 2.x.
  * Update README.md to reflect that this change drops support for < 5.0 (too many changes)

- elasticsearch_install:
  * Drop warnings for installing as root under ES < 2.0

- elasticsearch_configure:
  * Replace logging.yml with new log4j2.properties file, add template for this
  * Update variables that are allowed in /etc/sysconfig/elasticsearch or /etc/default/elasticsearch
  * Drop ES_JAVA_OPTS and introduce option 'jvm_options' with new template for /etc/elasticsearch/jvm.options
  * Add new restart_on_upgrade option, drop thread_stack_size, drop env_options, drop gc_settings
  * Drop some of the defaults in elasticsearch.yml that are no longer present in upstream packaging

- elasticsearch_plugin:
  * change bin/plugin to bin/elasticsearch-plugin when managing plugins
  * Remove the shield/watcher plugin installs, since they have become x-pack in ES 5.0
  * Add new `options` parameter/attribute so that you can pass things like `--batch` to this resource

- elasticsearch_service:
  * Introduce systemd unit files for distros that support them, copy latest init scripts for all platforms
  * Guard on which init systems based on presence of /etc/init.d or /usr/lib/systemd/system directories

Fixes #424.
Fixes #478.
Fixes #503.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Major version v3.0.0
Development

No branches or pull requests
2 participants
@martinb3 @wfindley