Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update data_dir permissions #112

Merged
merged 1 commit into from
Dec 3, 2020
Merged

update data_dir permissions #112

merged 1 commit into from
Dec 3, 2020

Conversation

v-andrius
Copy link
Contributor

@v-andrius v-andrius commented Dec 2, 2020 •
edited by ramereth
Loading

Description

update data_dir mode to 0700 to fix warning on v3.4.14: etcd-io/etcd#12242

etcd[709]: check file permission: directory "/hostname.etcd" exist, but the permission is "drwxr-xr-x". The recommended permission is "-rwx------" to prevent possible unprivileged access to the data.

Check List

  • All tests pass. See TESTING.md for details.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@ramereth ramereth added the Release: Patch Release to Chef Supermarket as a version patch when merged label Dec 2, 2020
ramereth
ramereth requested changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@ramereth ramereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can safely ignore the failure on Fedora as it looks like upstream hasn't released packages for F33 yet.

CHANGELOG.md Outdated Show resolved Hide resolved
@v-andrius v-andrius force-pushed the fix/data_dir_permissions branch from 66ab1f8 to e3cadb5 Compare December 3, 2020 15:36
@v-andrius
Setting permissions to 0700 on data_dir to fix warning on v3.4.14:
d24a4f3 
>etcd[709]: check file permission: directory "/hostname.etcd" exist, but the permission is "drwxr-xr-x". The recommended permission is "-rwx------" to prevent possible unprivileged access to the data.
@v-andrius v-andrius force-pushed the fix/data_dir_permissions branch from e3cadb5 to d24a4f3 Compare December 3, 2020 15:36
@ramereth ramereth added Release: Minor Release to Chef Supermarket as a minor release when merged and removed Release: Patch Release to Chef Supermarket as a version patch when merged labels Dec 3, 2020
ramereth
ramereth approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@ramereth ramereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this may impact users, I'm going to release this as a minor release.

@ramereth ramereth merged commit 5a206ee into sous-chefs:master Dec 3, 2020
@kitchen-porter
Copy link
Contributor

Released as: 6.2.0

@v-andrius v-andrius deleted the fix/data_dir_permissions branch December 4, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramereth ramereth ramereth approved these changes

Assignees
No one assigned
Labels
Release: Minor Release to Chef Supermarket as a minor release when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-andrius @kitchen-porter @ramereth