Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support use of symlinks for device paths #133

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

SlashDashAndCash
Copy link
Contributor

This change improves the mounted? check

  1. Symlinks are now resolved to their canonical path
  2. Checks if the device is mounted to a specific mount point

Description

This pull request is similar to #130 by jrmycanady but also canonicalizes device paths in /proc/mounts. This is necessary because device paths in /prod/mount can be symlinks as well. For example, /dev/mapper/system-root referes to /dev/dm-0.

Issues Resolved

129 - filesystem tries to run mkfs every time when /dev/disk/by-id device path is used

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

This change improves the mounted? check. Symlinks are now resolved to
their canonical path. Checks if the device is mounted at a specific mount point

Signed-off-by: Jakob Pfeiffer <jakob.pfeiffer@m-net.de>
@damacus damacus added the Release: Minor Release to Chef Supermarket as a minor release when merged label Dec 15, 2024
@damacus damacus merged commit c37ab2c into sous-chefs:main Dec 15, 2024
9 of 10 checks passed
@kitchen-porter
Copy link
Contributor

Released as: 4.2.0

@damacus
Copy link
Member

damacus commented Dec 15, 2024

Thanks for updating and fixing that. A good reminder that, I don't use every cookbook in the collection and there's a decent level of trust that it works as described 😂😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release: Minor Release to Chef Supermarket as a minor release when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants