Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iis_vdir name to not require a trailing / #363

Merged
merged 1 commit into from
May 16, 2017

Conversation

EasyAsABC123
Copy link
Contributor

Description

Allows iis_vdir to not require a trailing / in the name property

Issues Resolved

#361

Check List

@EasyAsABC123 EasyAsABC123 added Priority: Low Is a nice to have, not an essential Status: Maintainer Review Needed labels May 16, 2017
@EasyAsABC123 EasyAsABC123 requested a review from iennae May 16, 2017 03:17
Signed-off-by: Justin Schuhmann <jmschu02@gmail.com>
@EasyAsABC123 EasyAsABC123 force-pushed the enhancement-iis_vdir_add_command_ending_slash branch from d583ca7 to 40f8b40 Compare May 16, 2017 03:20
@EasyAsABC123 EasyAsABC123 merged commit 3037029 into master May 16, 2017
@EasyAsABC123 EasyAsABC123 deleted the enhancement-iis_vdir_add_command_ending_slash branch May 16, 2017 03:41
Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

kamaradclimber added a commit to criteo-forks/iis that referenced this pull request Jul 18, 2017
Most of the merge work is based on the fact that pool provider has been
replaced by a custom resource.

From all the non-merged criteo patches:
51e609a Fix decoding of entities in XML
5034448 Clarify execute tasks
43186f1 Activate use_inline_resources
99c4187 Remove unnecessary Chef logs
280fba8 Fix regression introduced with whyrun support
e85ca2f Fix the site_identifier privacy so that the execute context can use it
12ac82f Post review fixes
d534851 Removed new_resource.updated_by_last_action occurences
f9b773d Make the pool provider whyrun able

all are either unnecessary or correctly applied

* 'master' of https://github.com/chef-cookbooks/iis: (145 commits)
  Adds better documentation for the options parameter (sous-chefs#383)
  release 6.7.2 (sous-chefs#382)
  Fix FTP site binding error (sous-chefs#380)
  Release v6.7.1 (sous-chefs#379)
  Fix issue with guard clause missing on check (sous-chefs#378)
  Release v6.7.0 (sous-chefs#376)
  fix multiple bugs with iis_vdir iis_root iis_app for idempotency (sous-chefs#375)
  Release v6.6.0 (sous-chefs#373)
  Update appveyor.yml
  Enhancement module custom resource (sous-chefs#372)
  Fix README.md (sous-chefs#367)
  Release v6.5.3 (sous-chefs#371)
  Resolves a bug in iis_vdir also adds more liberty in config (sous-chefs#370)
  Refactor vdir name property to site_name (sous-chefs#359)
  Release v6.5.2 (sous-chefs#364)
  Update iis_vdir name to not require a trailing / (sous-chefs#363)
  Fix iis_pool identity_type issue (sous-chefs#362)
  Release v6.5.1 (sous-chefs#358)
  Add quotes to pool name (sous-chefs#357)
  Release v6.5.0 (sous-chefs#352)
  ...

Change-Id: I951fb2d1788d877c98b24bb22cb5d035162e146d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Is a nice to have, not an essential
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants