Add the default-java symlink to Oracle JDK #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was thinking about this myself after cutting the last release. I'm thinking we should refactor these into a new recipe called default_java_symlink.rb or something, and then include_recipe that in both of these locations. Care to update this PR with that change? |
|
Updated with the refactoring. Also added the same fix to |
|
Looks good, but we can pull the tests out of oracle_spec and oracle_i386_spec into a new default_java_symlink_spec. |
|
(+1) |
carmstrong
added a commit
that referenced
this pull request
Mar 15, 2014
Add the default-java symlink to Oracle JDK
carmstrong
added a commit
that referenced
this pull request
Mar 15, 2014
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.