Make exit code success when Steep has unreported type errors

soutaro · Jul 23, 2020 · 33f507b · 33f507b
1 parent f1d67ac
commit 33f507b
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/lib/steep/project/target.rb b/lib/steep/project/target.rb
@@ -205,7 +205,7 @@ def no_error?
       def errors
         case status
         when TypeCheckStatus
-          source_files.each_value.flat_map(&:errors)
+          source_files.each_value.flat_map(&:errors).select { |error | options.error_to_report?(error) }
         else
           []
         end

diff --git a/test/target_test.rb b/test/target_test.rb
@@ -102,6 +102,29 @@ class Foo
       end
     end
 
+    def test_success_type_check_with_unreported_errors
+      target = Project::Target.new(
+        name: :foo,
+        options: Project::Options.new.tap { |o| o.apply_lenient_typing_options! },
+        source_patterns: ["lib"],
+        ignore_patterns: [],
+        signature_patterns: ["sig"]
+      )
+
+      target.add_source Pathname("lib/foo.rb"), <<-EOF
+Foo = 1
+      EOF
+
+      target.type_check
+
+      assert_equal Project::Target::TypeCheckStatus, target.status.class
+      assert_empty target.errors
+      target.source_files[Pathname("lib/foo.rb")].tap do |file|
+        assert_equal Project::SourceFile::TypeCheckStatus, file.status.class
+        refute_empty file.status.typing.errors
+      end
+    end
+
     def test_signature_syntax_error
       target = Project::Target.new(
         name: :foo,