Merge pull request #177 from soutaro/fix-validation

Fix signature validation

lib/steep/server/signature_worker.rb

@@ -112,6 +112,9 @@ def validate_signature(target, timestamp:)
                         target.signature_files.each_key.with_object({}) do |path, hash|
                           hash[path] = []
                         end
+                      when Project::Target::SignatureOtherErrorStatus
+                        Steep.log_error status.error
+                        {}
                       else
                         Steep.logger.info "Unexpected target status: #{status.class}"
                         {}

lib/steep/signature/validator.rb

@@ -53,6 +53,7 @@ def validate
         validate_decl
         validate_const
         validate_global
+        validate_alias
       end
 
       def validate_type(type)
@@ -99,6 +100,7 @@ def validate_const
         env.constant_decls.each do |name, entry|
           rescue_validation_errors do
             Steep.logger.debug "Validating constant `#{name}`..."
+            builder.ensure_namespace!(name.namespace, location: entry.decl.location)
             validate_type entry.decl.type
           end
         end
@@ -117,7 +119,9 @@ def validate_alias
         env.alias_decls.each do |name, entry|
           rescue_validation_errors do
             Steep.logger.debug "Validating alias `#{name}`..."
-            validate_type(entry.decl.type)
+            builder.expand_alias(name).tap do |type|
+              validate_type(type)
+            end
           end
         end
       end

steep.gemspec

@@ -34,5 +34,5 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency "rainbow", ">= 2.2.2", "< 4.0"
   spec.add_runtime_dependency "listen", "~> 3.1"
   spec.add_runtime_dependency "language_server-protocol", "~> 3.14.0.2"
-  spec.add_runtime_dependency "rbs", "~> 0.8.0"
+  spec.add_runtime_dependency "rbs", "~> 0.9.0"
 end

test/type_construction_test.rb

@@ -1022,6 +1022,10 @@ class Address
   def test_class_constructor_nested
     with_checker <<-EOF do |checker|
 class Steep::Names::Module end
+module Steep
+  class Names
+  end
+end
     EOF
       source = parse_ruby("module Steep; class Names::Module; end; end")
 
@@ -1120,6 +1124,8 @@ module Rails end
   def test_module_constructor_nested
     with_checker <<-EOS do |checker|
 module Steep::Printable end
+
+class Steep end
     EOS
       source = parse_ruby("class Steep; module Printable; end; end")
 

test/validation_test.rb

@@ -223,6 +223,51 @@ class Foo
     end
   end
 
+  def test_outer_namespace
+    with_checker <<-EOF do |checker|
+class Foo::Bar
+end
+    EOF
+
+      validator = Validator.new(checker: checker)
+      validator.validate
+
+      assert_operator validator, :has_error?
+      assert_any! validator.each_error do |error|
+        assert_instance_of Errors::UnknownTypeNameError, error
+        assert_equal parse_type("::Foo").name, error.name
+      end
+    end
+
+    with_checker <<-EOF do |checker|
+type Foo::bar = Integer
+    EOF
+
+      validator = Validator.new(checker: checker)
+      validator.validate
+
+      assert_operator validator, :has_error?
+      assert_any! validator.each_error do |error|
+        assert_instance_of Errors::UnknownTypeNameError, error
+        assert_equal parse_type("::Foo").name, error.name
+      end
+    end
+
+    with_checker <<-EOF do |checker|
+Foo::Bar: Integer
+    EOF
+
+      validator = Validator.new(checker: checker)
+      validator.validate
+
+      assert_operator validator, :has_error?
+      assert_any! validator.each_error do |error|
+        assert_instance_of Errors::UnknownTypeNameError, error
+        assert_equal parse_type("::Foo").name, error.name
+      end
+    end
+  end
+
   def test_validate_module
     skip "Not implemented yet"
   end