Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unexpected error #411

Merged
merged 1 commit into from
Aug 22, 2021
Merged

Fix Unexpected error #411

merged 1 commit into from
Aug 22, 2021

Conversation

ksss
Copy link
Contributor

@ksss ksss commented Aug 20, 2021

If RBS::MixinClassError is raised during a steep check, the steep worker thread will be in a wait state forever.

With this fix, not only will steep not stop when RBS::MixinClassError is raised, but it will also show the problem.

mixin-class-error.rbs:5:2: [error] Cannot include a class `::Foo` in the definition of `::Bar`
│ Diagnostic ID: RBS::MixinClassError
│
└   include Foo
    ~~~~~~~~~~~

:#<NoMethodError: undefined method `content' for nil:NilClass>
Copy link
Owner

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉 🖊️

@soutaro
Copy link
Owner

soutaro commented Aug 22, 2021

Oops the implementation looks good, but still has test failure...

@soutaro
Copy link
Owner

soutaro commented Aug 22, 2021

@ksss The test failures should be fixed in #413. Could you try rebasing on the master branch?

@soutaro
Copy link
Owner

soutaro commented Aug 22, 2021

I run test locally and confirmed it passes.

@soutaro soutaro merged commit 7c2c9f2 into soutaro:master Aug 22, 2021
@ksss
Copy link
Contributor Author

ksss commented Aug 22, 2021

Thanks ✨

@ksss ksss deleted the mixin-class-error branch August 22, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants