Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting display of CompletionItem #442

Merged
merged 1 commit into from
Nov 14, 2021
Merged

Conversation

ksss
Copy link
Contributor

@ksss ksss commented Oct 1, 2021

There are two problems with the current completion function.

  • If I want to complete a method such as default_value, def part will be completed.
  • Type parameters are also being completed.
before-10.mov

So, the following fixes have been made.

  • Remove the def part from the completion target.
  • Remove type parameters from the completion target as well. Instead, put type parameters in detail.

This solves the problem, but the downside is that the type parameter that used to show up in all completion lists is now only the one you have selected.

after-10.mov

Copy link
Owner

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for sending the patch!

(I was thinking of using filterText attribute in fact, but deleting def and the types would look better.)

@soutaro soutaro merged commit 0ff8eb9 into soutaro:master Nov 14, 2021
@ksss ksss deleted the CompletionItem branch November 15, 2021 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants