Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Support Windows environment #514

Merged
merged 5 commits into from
Mar 20, 2022

Conversation

sevenc-nanashi
Copy link
Contributor

This PR adds support for Windows.
Sometimes drive letter (e:) is missing (maybe language_server-protocol bug?), so it may error if the work that is on multiple drives.
image

This closes #383.

@sevenc-nanashi sevenc-nanashi marked this pull request as draft March 18, 2022 09:55
@sevenc-nanashi sevenc-nanashi marked this pull request as ready for review March 19, 2022 01:47
Gemfile Outdated Show resolved Hide resolved
Copy link
Owner

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to merge this PR after fixing the two problems I mentioned.

lib/steep/server/master.rb Outdated Show resolved Hide resolved
sevenc-nanashi and others added 2 commits March 20, 2022 15:49
Co-authored-by: Soutaro Matsumoto <matsumoto@soutaro.com>
Co-authored-by: Soutaro Matsumoto <matsumoto@soutaro.com>
@sevenc-nanashi
Copy link
Contributor Author

Fixed, thank you for reviewing my code 🙇🏼

@sevenc-nanashi sevenc-nanashi requested a review from soutaro March 20, 2022 07:33
Copy link
Owner

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@soutaro soutaro merged commit 2d20b94 into soutaro:master Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run steep check against Windows environment
2 participants