fix: [#4007] Bot framework V4. Unable to use ⭐ emoji in suggested actions #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1602294238
💛 - Coveralls |
sw-joelmut
approved these changes
Dec 20, 2021
NahuelPerales
approved these changes
Dec 20, 2021
|
Promoted to MS in PR# 4031 |
ceciliaavila
deleted the
southworks/add/dialogs-choices-findexactmatch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # 4007
Description
This PR ports the changes in dotnet PR#4671 to add the findExactMatch function in
botbuilder-dialogs/choicesto check for exact matches and bypass the tokenizer logic if an exact match is found.Specific Changes
findValuesclass to check for exact matches and bypass the rest of its logic if an exact match is found.Testing
These images show the star choice being ignored, and after the fix, being properly recognized.
