port: [#3922] Corrected GetConversationMembers to use TeamsInfo helper class rather… (#5874) #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceciliaavila
changed the title
ceciliaavila
changed the title
ceciliaavila
requested changes
Mar 9, 2022
libraries/botbuilder-dialogs-adaptive/src/actions/getActivityMembers.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-dialogs-adaptive/src/actions/getActivityMembers.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-dialogs-adaptive/src/actions/getActivityMembers.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-dialogs-adaptive/src/actions/getActivityMembers.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-dialogs-adaptive/src/actions/getConversationMembers.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-dialogs-adaptive/src/actions/getConversationMembers.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-dialogs-adaptive/src/actions/getConversationMembers.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-dialogs-adaptive/src/actions/getConversationMembers.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-dialogs-adaptive/src/actions/getConversationMembers.ts
Outdated
Show resolved
Hide resolved
ceciliaavila
approved these changes
Mar 9, 2022
ceciliaavila
deleted the
southworks/port/correct-getConversationMembers-to-use-teaminfo
branch
|
Promoted to MS in PR# 4151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # 3922
#minor
Description
This PR ports the changes in [BotBuider-DotNet](https://github.com/microsoft/botbuilder-dotnet/pull/ 5874) to Corrected GetConversationMembers in Adaptive.Runtime to use TeamsInfo helper class rather than rely on BotFrameworkAdapter functions that aren't available now that CoreBotAdapter derives from CloudAdapter and not BotFrameworkAdapter.
Specific Changes
Testing
These images show the unit tests passing after the changes.
