Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testbot to parity with DotNet #47

Merged
merged 2 commits into from
Jun 6, 2019

Conversation

Bill7zz
Copy link

@Bill7zz Bill7zz commented May 28, 2019

Description

We updated the testbot project to have parity with the Botbuilder-DotNet implementation in the PR#1946 that configured an endpoint for each bot in the testbot project. To do that, we separated the bot logic from index.js file and added a new post method with the route '/api/testbot' to handle the messages sent to the testbot.

Additionally, we updated the package-lock.json to get the latest version of the botbuilder libraries.

Specific Changes

  • Separate the bot logic from the index.js file
  • Update the package-lock.json

Testing

image

@Bill7zz Bill7zz requested a review from gasper-az May 28, 2019 15:19
@Bill7zz Bill7zz marked this pull request as ready for review May 28, 2019 15:21
- Separate the bot logic from the index.js file
- Update the package-lock.json
@Bill7zz Bill7zz force-pushed the testbot-refactor-dotnet-parity branch from 6bd4fda to 6293258 Compare May 28, 2019 19:13
libraries/testbot/index.js Outdated Show resolved Hide resolved
@Bill7zz Bill7zz force-pushed the testbot-refactor-dotnet-parity branch from d62b142 to 048cbcf Compare May 28, 2019 19:53
@Bill7zz Bill7zz force-pushed the testbot-refactor-dotnet-parity branch from 048cbcf to 875129a Compare May 28, 2019 19:59
@gasper-az gasper-az merged commit 875129a into master Jun 6, 2019
@gasper-az gasper-az deleted the testbot-refactor-dotnet-parity branch September 16, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants