Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4684] ESLint issues in botbuilder-lg #500

Open
wants to merge 1 commit into
base: southworks/update/eslint-packages
Choose a base branch
from

Conversation

ceciliaavila
Copy link

Addresses # 4684
#minor

Description

This PR fixes the new ESLint errors and warnings that occur after upgrading the ESLint packages in the botbuilder-lg project.

Specific Changes

  • Removed the 'only-warnings' plugin from 'botbuilder-lg/eslint.config.cjs' file and the related dependency.
  • Applied the auto fix flag for most issues (spacing, trailing commas, indentation, and removal of unnecessary eslint exceptions).
  • Applied manual fixes for new rules like 'no-require-imports'.

Testing

The following images show the number of issues fixed in the library and the tests passing after the changes.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants