Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sorting to the list of connectors #386

Merged
merged 5 commits into from
Dec 2, 2024

Conversation

illfixit
Copy link
Collaborator

@illfixit illfixit commented Dec 2, 2024

What issues does this PR close?

Checklist

Preview Give feedback

@illfixit illfixit enabled auto-merge (squash) December 2, 2024 14:58
Copy link
Collaborator

@kamilczaja kamilczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, sorting by creation date is rather counter-intuitive though.
Business input is sorting by connector name (ascending)

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Kamil Czaja <46053356+kamilczaja@users.noreply.github.com>
@illfixit illfixit requested a review from kamilczaja December 2, 2024 16:55
Copy link
Collaborator

@kamilczaja kamilczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@illfixit illfixit merged commit 37c52dd into main Dec 2, 2024
12 checks passed
@illfixit illfixit deleted the 67-frequent-re-ordering-in-connector-overview branch December 2, 2024 16:58
kamilczaja pushed a commit that referenced this pull request Dec 3, 2024
kamilczaja pushed a commit that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants