Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change client id generation for connectors central components #394

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ please see [changelog_updates.md](docs/dev/changelog_updates.md).
- Fixed an issue wherein it was possible to bypass the CaaS request limit in an organization ([PR #384](https://github.com/sovity/authority-portal/pull/384))
- Fixed an issue wherein a user registration could fail due to a mismatch of the internal database and the Keycloak database
- Fixed an issue where entries in the connector overview would randomly switch places ([PR #386](https://github.com/sovity/authority-portal/pull/386))
- Changed Client ID generation for Connectors & Central Components ([#327](https://github.com/sovity/authority-portal/issues/327))

### Known issues

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ class ClientIdUtils {

fun generateFromConnectorId(connectorId: String): String {
return connectorId
.replace(".", "-")
.lowercase(Locale.getDefault())
}

fun exists(clientId: String): Boolean {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ class CaasManagementApiServiceTest {
.withOffsetDateTimeComparator()
.withStrictTypeChecking()
.isEqualTo(expected.copy())
assertThat(actual.connectorId).isEqualTo(actual.clientId)
}

@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,7 @@ class ConnectorManagementApiServiceTest {
.withOffsetDateTimeComparator()
.withStrictTypeChecking()
.isEqualTo(expected.copy())
assertThat(actual.connectorId).isEqualTo(actual.clientId)
}

@Test
Expand Down
Loading